Re: feature request for svn mode

["G. Milde" <milde@xxxxxxxxxxxxxxxxxxxxx>]

On 22.10.07, Joachim Schmitz wrote:
> I am using successfully the svn.sl from the modes.csv.

I am glad to hear this :-)

> When prompting for the comment on commit, it would be nice if one could get 
> the same editing buffer, which one gets if you call
> `svn ci` from the commandline,
> a multiline buffer would also be sufficient.

I fully agree with this. (Maybe it is not needed in the case of just one
commited file.)

It is already on my TODO list. Unfortunately, I do not know how to get
svn to output this text into an existing jed. (Looks like I have to
revise the idea of a `jed-remote` command.)

Another option would be to emulate the svn behaviour (listing all changed
files, remembering to do this recursively for directories, ...).

A quick hack is to remove the -m argument from options passed to svn. If
your default editor is xjed, a new editor will pop up for the log message.
The patch below does just this (but it not tested).

Thanks,

Günter



--- /home/milde/.jed/jedmodes/src/mode/svn/svn.sl	2007-10-18 11:42:18.000000000 +0200
+++ /home/milde/.jed/lib/svn.sl	2007-10-23 08:31:39.000000000 +0200
@@ -157,6 +157,7 @@
 % 2007-08-02 * Revised layout and hotkeys of vc and vc_list_mode menu
 % 2007-10-01   Bugfix (missing variable declaration)
 % 2007-10-18 * vc_add_dir(): Non-recursive also under SVN
+% UNPUB      * Key_Ins selects and moves down one line
 %                           
 % TODO
 % ====
@@ -167,6 +168,27 @@
 % * syntax highlight (DFA) in directory listing
 % * fit_window() for popup buffers
 % * support for SVK (http://svk.bestpractical.com/)
+% 
+% On 22.10.07, Joachim Schmitz wrote:
+%
+% > When prompting for the comment on commit, it would be nice to get 
+% > the same editing buffer, which one gets if you call
+% > `svn ci` from the commandline,
+% > a multiline buffer would also be sufficient.
+% 
+% I fully agree with this. (Maybe it is not needed in the case of just one
+% commited file.)
+% 
+% Unfortunately, I do not know how to get svn to output this text into an
+% existing jed. (Looks like I have to revise the idea of a `jed-remote`
+% command.)
+% 
+% Another option would be to emulate the svn behaviour (listing all changed
+% files, remembering to do this recursively for directories, ...).
+% 
+% A quick hack is to remove the -m argument from options passed to svn. If
+% your default editor is xjed, a new editor will pop up for the log message.
+
 
 #<INITIALIZATION>
 % Add a "File>Version Control" menu popup
@@ -445,9 +467,9 @@
     (file, dir) = require_buffer_file_in_vc();
     save_buffer();
     
-    variable message = read_mini("Committing '" + file +"'. Log message: ", "", "");
+    % variable message = read_mini("Committing '" + file +"'. Log message: ", "", "");
     
-    do_vc([ "commit", "-m", message, file ], dir, 1, 1);
+    % do_vc([ "commit", "-m", message, file ], dir, 1, 1);
     reload_buffer();
 }
 %}}}
@@ -875,9 +897,9 @@
     variable dir, rfiles;    
     (dir, rfiles) = find_marked_common_root();
     
-    variable message = read_mini("Committing all marked files. Log message: ", "", "");
+    % variable message = read_mini("Committing all marked files. Log message: ", "", "");
     
-    do_vc(["commit", "-m", message, rfiles], dir, 1, 1);
+    % do_vc(["commit", "-m", message, rfiles], dir, 1, 1);
     
     vc_unmark_all();
 }
@@ -920,9 +942,9 @@
 public define vc_commit_selected() { %{{{
     variable dir, file;
     (dir, file) = extract_filename();    
-    variable message = read_mini("Committing '" + file + "'. Log message: ", "", "");
+    % variable message = read_mini("Committing '" + file + "'. Log message: ", "", "");
     
-    do_vc(["commit", "-m", message, file], dir, 1, 1);
+    % do_vc(["commit", "-m", message, file], dir, 1, 1);
 }
 %}}}
 
@@ -1105,7 +1127,7 @@
    definekey("vc_open_selected", "\r", kmap);
    definekey("vc_revert_selected", "r", kmap);
    
-   definekey("svn->toggle_marked", Key_Ins, kmap);
+   definekey("svn->toggle_marked; go_down_1", Key_Ins, kmap);
    definekey("svn->toggle_marked", "t", kmap);
    % definekey("svn->toggle_marked", " ", kmap);
    definekey("vc_unmark_all", "U", kmap);














--------------------------
To unsubscribe send email to <jed-users-request@xxxxxxxxxxx> with
the word "unsubscribe" in the message body.
Need help? Email <jed-users-owner@xxxxxxxxxxx>.