Re: bug(?) in black3 and Guido Gonzato's updates

[Jörg Sommer <joerg@xxxxxxxxxxxx>]

Hallo John,

"John E. Davis" <davis@xxxxxxxxxxxxx> wrote:
> Jörg Sommer <joerg@xxxxxxxxxxxx> wrote:
>> while using the new version I've observed that the color of keyword of
>> the color scheme black3 changed. Before the SVN commit for the changes
>> 197-199 the color was green, since these changes the color is read.
>> Was this an intended change? I don't worry about the color. I only
>> mention it, because it might be a side effect of this commit.
>
> That is odd--- I do not see that in the diffs:

Yes, me too. I thought it was the effect of a change anywhere else,
because black3.sl doesn't define keyword and keyword1. From which
color table these settings are inherited?

> --- a/lib/colors/black3.sl
> +++ b/lib/colors/black3.sl
> @@ -34,6 +34,7 @@ set_color("url", "brightgreen", $2);
>  set_color("italic", $1, $2);
>  set_color("underline", "green", $2);
>  set_color("bold", "brightred", $2);
> +set_color("html", "brightred", $2);
>  set_color("keyword2", $1, $2);
>  set_color("keyword3", $1, $2);
>  set_color("keyword4", $1, $2);
>

>> Update of matlab.sl from Guido Gonzato
>>
>> The file http://guido.gonzato.googlepages.com/matlab.sl contains a small
>> change of the file. Except the more worse readability of the expression
>> the result is different, because the decrement happens *after*
>> insert_spaces(). So, one more space is inserted than before.
>
> I disagree with the comment.  In fact, in slang there is no difference
> between
>
>    insert_spaces (goal--, goal);
>
> and
>
>    goal--;
>    insert_spaces (goal);

Oh, I've thought the equivalent code is insert_spaces (--goal, goal), but
you are the developer of S‐Lang and you are right. Thanks for reviewing
these patches.

Bye, Jörg.
-- 
Der Wunsch, klug zu erscheinen, verhindert oft, es zu werden.
    	    	    			      (Francois de la Rochefoucauld)

--------------------------
To unsubscribe send email to <jed-users-request@xxxxxxxxxxx> with
the word "unsubscribe" in the message body.
Need help? Email <jed-users-owner@xxxxxxxxxxx>.