Re: patches in 0.99.19-208 (was Re: slang/slrn bug with CTRL-G / CTRL-Z combo)

[Jörg Sommer <joerg@xxxxxxxxxxxx>]

Hello John,

"John E. Davis" <davis@xxxxxxxxxxxxx> wrote:
> Jörg Sommer <joerg@xxxxxxxxxxxx> wrote:
>> I lost track of the development of jed. Did you add support for the
>> multikey (aka compose) in xjed? I have a patch that enables the multikey
>> but breaks copy & paste and redrawing of the window.
>
> I have added all of your patches-- they are in 0.99.19-208.  I
> modified the multikey patch so that copy+paste and redrawing appear
> work.  Do the patches work for you?  Thanks, --John

Yes, it works. I can use my multikey and copy&paste and redraw works.
Very good. Thanks for your work!

Now, I've some new problems:

• make distclean doesn't remove log files of failed tests. The test
  test_cmode failed and after running make distclean the file
  src/test/test_cmode.log still exists. Distclean should remove
  everything.

• With the commit for the changes 205–207 you've changed the test data
  for test_cmode, but this makes the test fail.
#v+
diff --git a/src/test/test_cmode.dat b/src/test/test_cmode.dat
index e05a0e0..b54b8da 100644
--- a/src/test/test_cmode.dat
+++ b/src/test/test_cmode.dat
@@ -209,5 +209,10 @@ int main (int argc, char **argv)
    if (bar)
      name = foo
      + bar;
+
+   (foo) 
+     = bar;
+   (bar)
+     = foo;
 }
 
#v-

And what's your opinion to the following patches? For the first to third
patch please remember this mail [1]. I can't recall what the result of
the discussion was, but without some tweaking [2] I get these warnings:

dpkg-shlibdeps: warning: dependency on libdl.so.2 could be avoided if "debian/jed/usr/bin/jed" were not uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if "debian/jed/usr/bin/jed" were not uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libdl.so.2 could be avoided if "debian/xjed/usr/bin/xjed" were not uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if "debian/xjed/usr/bin/xjed" were not uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libgpm.so.2 could be avoided if "debian/xjed/usr/bin/xjed" were not uselessly linked against it (they use none of its symbols).

[1] http://jupiter.jtan.com/~wingnut/jed-users/msg02215.html
[2] http://git.debian.org/?p=pkg-jed/jed.git;a=commitdiff;h=33069659e0ac671be7c888d1f6c1d0b27eae4b6b#patch2
  http://git.debian.org/?p=pkg-jed/jed.git;a=commitdiff;h=d5a4ccaea1e9550ce933961357e499a7c304b809

http://git.debian.org/?p=pkg-jed/jed.git;a=commitdiff;h=f75fe6d9f9306a1b28a4f9658b0c3fa6c31e1f99
Author: Jörg Sommer <joerg@xxxxxxxxxxxx>
Date:   Thu, 29 May 2008 21:42:51 +0200

Insert DYNAMIC_LINK_FLAGS directly into LDFLAGS

There's no need to carry these flags in a separate variable.

 autoconf/aclocal.m4   |   11 +----------
 autoconf/configure.ac |    2 +-
 src/Makefile.in       |    2 +-
 3 files changed, 3 insertions(+), 12 deletions(-)

http://git.debian.org/?p=pkg-jed/jed.git;a=commitdiff;h=e244a954931f453c0ee0ed5a012567f75d4b7ff7
Author: Jörg Sommer <joerg@xxxxxxxxxxxx>
Date:   Fri, 30 May 2008 00:26:13 +0200

Replace check for dlopen by check for SLang_init_import

The function dlopen is not used directly in Jed, but the function
SLang_init_import.

 autoconf/aclocal.m4   |   19 -------------------
 autoconf/configure.ac |    2 ++
 src/Makefile.in       |    7 ++-----
 src/config.hin        |    8 ++++++--
 src/jed-feat.h        |    6 ------
 src/jedconf.h         |    4 ----
 6 files changed, 10 insertions(+), 36 deletions(-)

http://git.debian.org/?p=pkg-jed/jed.git;a=commitdiff;h=4f0c38503694ace5174ae1bf6c7c0bc4b1d20454
Author: Jörg Sommer <joerg@xxxxxxxxxxxx>
Date:   Thu, 29 May 2008 22:22:46 +0200

Remove linker option -lm

The library math is not used by Jed. So we don't need to link with it.

 src/Makefile.in |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

http://git.debian.org/?p=pkg-jed/jed.git;a=commitdiff;h=8d62d0f896be1d03cb623d66623e057faca04091
Author: Jörg Sommer <joerg@xxxxxxxxxxxx>
Date:   Sun, 24 Aug 2008 17:41:40 +0200

Make return type of jed_malloc0() void*

The cast from char* to any other pointer type might increases required
alignment of target type. On some architectures (like alpha) this
triggers an error message at runtime, if the access of a pointer is
unaligned:

% cat cast-test.c
int main(void)
{
    char buf[10] = { 0 };
    int *a = (int*)&buf[1];
    *a = 0x7a7a7a;

    return 0;
}
% gcc -Wall -Wcast-align cast-test.c -o cast-test
cast-test.c: In function `main':
cast-test.c:4: warning: cast increases required alignment of target type
% ./cast-test
Unaligned access pid=398552 <cast-test> va=0x11fffbfe1 pc=0x12000112c ra=0x1200010ac inst=0xb0220000

 src/abbrev.c |    2 +-
 src/blocal.c |    2 +-
 src/buffer.c |    2 +-
 src/hooks.c  |    4 ++--
 src/indent.c |    2 +-
 src/menu.c   |    4 ++--
 src/misc.c   |    6 +++---
 src/misc.h   |    2 +-
 src/paste.c  |   10 +++++-----
 src/screen.c |    2 +-
 src/vterm.c  |    2 +-
 src/window.c |    2 +-
 12 files changed, 20 insertions(+), 20 deletions(-)

http://git.debian.org/?p=pkg-jed/jed.git;a=commitdiff;h=e87ddd7262a57e303ec52fb7c080bba6e27a7794
Author: Jörg Sommer <joerg@xxxxxxxxxxxx>
Date:   Sun, 24 Aug 2008 18:34:57 +0200

Use intermediate void* pointer for SLmalloc() return values

The cast from char* to any other pointer type might increases required
alignment of target type. This causes problems on some architectures
(like alpha).

Fix it by saving the result of SLmalloc() and SLrealloc() to a void*
pointer and then copy it to the target variable.

 src/abbrev.c   |    6 +++++-
 src/buffer.c   |   14 +++++++++++---
 src/dfasyntx.c |   42 ++++++++++++++++++++++++++++++++++--------
 src/hooks.c    |    5 ++++-
 src/ledit.c    |    5 ++++-
 src/menu.c     |   22 ++++++++++++++++++----
 src/undo.c     |    6 +++++-
 src/vfile.c    |    6 +++++-
 src/vterm.c    |    6 +++++-
 src/xterm.c    |   15 ++++++++++++---
 10 files changed, 103 insertions(+), 24 deletions(-)

http://git.debian.org/?p=pkg-jed/jed.git;a=commitdiff;h=66d414cf0ffc26f3bca7195a36a3e4c127e0f4cc
Author: Jörg Sommer <joerg@xxxxxxxxxxxx>
Date:   Thu, 18 Sep 2008 12:11:56 +0200

Description for send_process

 doc/tm/rtl/process.tm |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

http://git.debian.org/?p=pkg-jed/jed.git;a=commitdiff;h=456f22085fafbdc310fed2c33a99d3d5c7476d36
Author: Jörg Sommer <joerg@xxxxxxxxxxxx>
Date:   Sat, 6 Dec 2008 01:15:15 +0100

Use special function to set user info

Small code refactoring: Use the specialized functions to set the user
information instead of changing the raw data structures.

 src/userinfo.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


Regards, Jörg.
-- 
Das Recht, seine Meinung zu wechseln, ist eines der wichtigsten
menschlichen Privilegien.
	     		 			(Robert Peel)

--------------------------
To unsubscribe send email to <jed-users-request@xxxxxxxxxxx> with
the word "unsubscribe" in the message body.
Need help? Email <jed-users-owner@xxxxxxxxxxx>.